New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[App] fix `lightning open` command & better redirects #16794

Merged

yurijmikhalevich merged 4 commits into master from fix/app-urls

Feb 17, 2023

Member

yurijmikhalevich commented Feb 17, 2023 •

edited by github-actions bot

What does this PR do?

Fixes lightning open command & post-execution redirects.

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

github-actions bot added the app label

yurijmikhalevich force-pushed the fix/app-urls branch from 6807d78 to 2c38190 Compare

February 17, 2023 13:38

yurijmikhalevich marked this pull request as ready for review

February 17, 2023 13:41

yurijmikhalevich requested review from tchaton, lantiga, awaelchli, hhsecond and ethanwharris as code owners

February 17, 2023 13:41

yurijmikhalevich changed the title ~~[App]: fix lightning open command & better redirects~~ [App] fix lightning open command & better redirects

Contributor

github-actions bot commented Feb 17, 2023 •

edited

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning/app/runners/cloud.py, tests/tests_app/runners/test_cloud.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning/app/runners/cloud.py.

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

These checks are required after the changes to src/lightning/app/runners/cloud.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (lightning)	success	✅
make-html (lightning)	success	✅

These checks are required after the changes to src/lightning/app/runners/cloud.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/app/runners/cloud.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/app/runners/cloud.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

tchaton approved these changes

View reviewed changes

Contributor

tchaton left a comment

Love it ! Any tests you could add to avoid regression ?

awaelchli added the bug label

awaelchli added this to the v1.9.x milestone

Member

awaelchli commented Feb 17, 2023

+1 for adding a test :)

yurijmikhalevich and others added 3 commits

February 17, 2023 20:11


          fix(app): URLs, create run on app run


          [pre-commit.ci] auto fixes from pre-commit.com hooks

6366f2d

for more information, see https://pre-commit.ci


          fix tests

b77ca87

yurijmikhalevich force-pushed the fix/app-urls branch from 2c38190 to b77ca87 Compare

February 17, 2023 17:36


          [pre-commit.ci] auto fixes from pre-commit.com hooks

4c87a99

for more information, see https://pre-commit.ci

yurijmikhalevich enabled auto-merge (squash)

February 17, 2023 17:48

rlizzo approved these changes

View reviewed changes

mergify bot added the ready label

ethanwharris approved these changes

View reviewed changes

Member

ethanwharris left a comment

Thanks for this!

hhsecond approved these changes

View reviewed changes

yurijmikhalevich merged commit 6950a07 into master

yurijmikhalevich deleted the fix/app-urls branch

February 17, 2023 18:24

awaelchli pushed a commit that referenced this pull request


          [App] fix lightning open command & better redirects (#16794)

01f048b

* fix(app): URLs, create run on app run

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

carmocca pushed a commit that referenced this pull request


          [App] fix lightning open command & better redirects (#16794)

18e1e63

* fix(app): URLs, create run on app run

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

lexierule pushed a commit that referenced this pull request


          [App] fix lightning open command & better redirects (#16794)

494ce3e

* fix(app): URLs, create run on app run

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ethanwharris ethanwharris approved these changes

tchaton tchaton approved these changes

hhsecond hhsecond approved these changes

rlizzo rlizzo approved these changes

lantiga Awaiting requested review from lantiga lantiga is a code owner

awaelchli Awaiting requested review from awaelchli awaelchli is a code owner