Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log gradient norms of any magnitude #16877

Merged
merged 4 commits into from Feb 28, 2023
Merged

Conversation

martenlienen
Copy link
Contributor

What does this PR do?

After just having spent 3 hours trying to figure out, why some of parameters apparently receive no gradients, I found out that grad_norm arbitrarily decides that gradient norms less than 1e-4 are not worth knowing about and rounds them to zero. This PR fixes that.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 26, 2023
@awaelchli awaelchli added the community This PR is from the community label Feb 26, 2023
@awaelchli awaelchli added this to the 2.0 milestone Feb 26, 2023
@awaelchli awaelchli added the logging Related to the `LoggerConnector` and `log()` label Feb 26, 2023
Copy link
Member

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a CHANGELOG entry? Under the "Changed" section

src/lightning/pytorch/utilities/grads.py Show resolved Hide resolved
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mergify mergify bot added the ready PRs ready to be merged label Feb 27, 2023
@martenlienen
Copy link
Contributor Author

Thanks for the review and information. I have added a changelog entry.

@awaelchli awaelchli enabled auto-merge (squash) February 27, 2023 13:22
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Feb 27, 2023
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Feb 27, 2023
@awaelchli awaelchli merged commit 7bc39ae into Lightning-AI:master Feb 28, 2023
9 of 10 checks passed
@martenlienen martenlienen deleted the patch-1 branch August 23, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community logging Related to the `LoggerConnector` and `log()` pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants