Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_size mode to CombinedLoader #16939

Merged
merged 7 commits into from Mar 6, 2023
Merged

Add max_size mode to CombinedLoader #16939

merged 7 commits into from Mar 6, 2023

Conversation

janpawlowskiof
Copy link
Contributor

@janpawlowskiof janpawlowskiof commented Mar 3, 2023

Adds max_size mode support to CombinedLoader, which works very much like max_size_cycle, but it returns Nones instead of cycling through exhausted iterables.

Discussed in #16917

Also includes added tests for NamedTuples support in CombinedLoader, which seemed to have been missing. Hopefully this does not break to PR does only one thing rule.

Also: First time contributing, yay!

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Mar 3, 2023
@janpawlowskiof janpawlowskiof marked this pull request as ready for review March 3, 2023 12:33
@awaelchli awaelchli added feature Is an improvement or enhancement data handling Generic data-related topic community This PR is from the community labels Mar 3, 2023
@awaelchli
Copy link
Member

There are some unrelated tests failing in the CI (red crosses). Don't worry about that, this will be resolved soon.

@carmocca carmocca self-assigned this Mar 6, 2023
@carmocca carmocca added this to the 2.0 milestone Mar 6, 2023
@mergify mergify bot added the ready PRs ready to be merged label Mar 6, 2023
@carmocca carmocca enabled auto-merge (squash) March 6, 2023 15:34
@carmocca carmocca merged commit 6781f35 into Lightning-AI:master Mar 6, 2023
93 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community This PR is from the community data handling Generic data-related topic feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants