New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use base version check before calling `_register_load_state_dict_pre_hook` #17030

Merged

awaelchli merged 6 commits into master from bugfix/base-version-check-2

Mar 14, 2023

Member

awaelchli commented Mar 10, 2023 •

edited by github-actions bot

What does this PR do?

Fixes #16644
Redo of #16657

I won't give up!

cc @Borda @tchaton


          redo

c9ace4e

github-actions bot added the pl label

awaelchli mentioned this pull request

Use base version when comparing torch versions #16657

Merged

11 tasks

pre-commit-ci bot and others added 2 commits

March 10, 2023 13:07


          [pre-commit.ci] auto fixes from pre-commit.com hooks

9a26288

for more information, see https://pre-commit.ci


          fix import

1d1ac7a

awaelchli marked this pull request as ready for review

March 10, 2023 23:32

awaelchli requested review from williamFalcon, tchaton and carmocca as code owners

March 10, 2023 23:32

awaelchli added bug priority: 0 labels

awaelchli added this to the v1.9.x milestone

Contributor

github-actions bot commented Mar 10, 2023 •

edited

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 2.0, pre)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.11)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 2.0, pre)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.11)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 2.0, pre)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅

These checks are required after the changes to src/lightning/pytorch/core/module.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to src/lightning/pytorch/core/module.py.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to src/lightning/pytorch/core/module.py.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to src/lightning/pytorch/core/module.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/pytorch/core/module.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/pytorch/core/module.py.

🟢 link-check

Check ID	Status
markdown-link-check	success	✅

These checks are required after the changes to src/lightning/pytorch/CHANGELOG.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

pre-commit-ci bot and others added 3 commits

March 10, 2023 23:33


          [pre-commit.ci] auto fixes from pre-commit.com hooks

92333f3

for more information, see https://pre-commit.ci


          chlog

e7ccd9b


          Merge remote-tracking branch 'origin/bugfix/base-version-check-2' int…

7f75c33

…o bugfix/base-version-check-2

awaelchli requested a review from justusschock as a code owner

March 10, 2023 23:34

carmocca approved these changes

View reviewed changes

Member Author

awaelchli commented Mar 14, 2023

We should probably land this for 2.0 and 1.9.x @Borda @justusschock :))

justusschock approved these changes

View reviewed changes

mergify bot added the ready label

awaelchli merged commit bc8c0f6 into master

80 of 81 checks passed

awaelchli deleted the bugfix/base-version-check-2 branch

March 14, 2023 14:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

carmocca carmocca approved these changes

justusschock justusschock approved these changes

williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

tchaton Awaiting requested review from tchaton tchaton is a code owner