New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include parent directory validation check for deepspeed #17795
Conversation
…rror message - Added a check to see if the passed checkpoint directory is a valid deepspeed directory - Raised an error indicating the checkpoint directory to be passed should be the parent directory
…ltigpu_single_file
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #17795 +/- ##
=========================================
- Coverage 84% 59% -25%
=========================================
Files 430 420 -10
Lines 32667 31977 -690
=========================================
- Hits 27319 18862 -8457
- Misses 5348 13115 +7767 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement in usability
What does this PR do?
Included a check for the checkpoint parent directory and enhanced the error message making the checkpoint validation more robust
Fixes #17763
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist