Utility function to check shared filesystem #18586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
feature
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
awaelchli
commented
Sep 20, 2023
awaelchli
commented
Sep 20, 2023
…ature/shared-fs-check
awaelchli
requested review from
carmocca,
justusschock,
edenlightning,
lantiga,
Borda and
tchaton
as code owners
carmocca
reviewed
Sep 20, 2023
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
for more information, see https://pre-commit.ci
Borda
reviewed
Sep 21, 2023
Borda
reviewed
Sep 21, 2023
Borda
approved these changes
Sep 21, 2023
It is not used anywhere at the moment. For now it is just a useful utility that can be used independently. But I'm looking into how this can be used in Lightning as well, and to make our examples better. |
carmocca
approved these changes
Sep 25, 2023
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a utility function to check whether given path resides on a shared filesystem that all processes that participate can access. This is useful to make code agnostic to the infrastructure without boilerplate code or user configuration.
Closes #11136 (I couldn't find any use cases anymore, let me know if you know one)
📚 Documentation preview 📚: https://pytorch-lightning--18586.org.readthedocs.build/en/18586/
cc @Borda @awaelchli @carmocca @justusschock