remove frame inspection on self.hparams #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @williamFalcon! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2020-06-19 02:36:49 UTC |
Borda
reviewed
Jun 19, 2020
| lines = class_code.split('\n') | ||
| for line in lines: | ||
| line = re.sub(r"\s+", "", line, flags=re.UNICODE) | ||
| if 'self.hparams=' in line: |
There was a problem hiding this comment.
this is a naive hack assuming user uses standard naming, it will fail on
class AAA(...):
def __init__(me, param1, ...):
me.hparams = param1
There was a problem hiding this comment.
nope... 'hparams' is a fallback... try it!
There was a problem hiding this comment.
the point is with rename self to me or what ever
There was a problem hiding this comment.
also what about spacing
self.hparams <50x spaces> = param1
or rename the vasiable
class AAA():
def __init__(me, param1):
copy_param = copy.deepcopy(param1)
me.hparams = copy_param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2250
Fixes #2188