Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: move train outside of setup training #3297

Merged
merged 4 commits into from Sep 1, 2020
Merged

ref: move train outside of setup training #3297

merged 4 commits into from Sep 1, 2020

Conversation

williamFalcon
Copy link
Contributor

No description provided.

@mergify mergify bot requested a review from a team August 31, 2020 23:18
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #3297 into master will increase coverage by 5%.
The diff coverage is 84%.

@@           Coverage Diff           @@
##           master   #3297    +/-   ##
=======================================
+ Coverage      86%     90%    +5%     
=======================================
  Files          88      88            
  Lines        8116    8130    +14     
=======================================
+ Hits         6952    7335   +383     
+ Misses       1164     795   -369     

@williamFalcon williamFalcon merged commit b0298ce into master Sep 1, 2020
@Borda Borda deleted the reff5 branch September 1, 2020 08:05
@Borda Borda added the refactor label Sep 1, 2020
@Borda Borda added this to the 0.9.x milestone Sep 1, 2020
# TRAIN
# --------------------------
self.train()
def train_or_test(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is quite confusing...

@mergify mergify bot requested a review from a team September 1, 2020 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants