Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mixin to core #8396

Merged
merged 3 commits into from Jul 19, 2021
Merged

Move mixin to core #8396

merged 3 commits into from Jul 19, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes ? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
  • Did you list all the breaking changes introduced by this pull request?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #8396 (e53b914) into master (000fbe6) will decrease coverage by 5%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8396    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         216     217     +1     
  Lines       14115   14116     +1     
=======================================
- Hits        13087   12423   -664     
- Misses       1028    1693   +665     

@Borda
Copy link
Member

Borda commented Jul 13, 2021

just curious, what is the motivation?

@mergify mergify bot removed the has conflicts label Jul 13, 2021
@kaushikb11
Copy link
Contributor Author

@Borda Reference

@carmocca carmocca added this to the v1.4 milestone Jul 13, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) July 13, 2021 14:42
Copy link
Member

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't the device_dtype_mixin require a rerouting of the imports for BC?

@kaushikb11
Copy link
Contributor Author

doesn't the device_dtype_mixin require a rerouting of the imports for BC?

I don't think it would be required for internal use.

@justusschock
Copy link
Member

justusschock commented Jul 19, 2021

@kaushikb11

I don't think it would be required for internal use.

Not for internal use, but it was part of the public API in utilities (I use it quite often in my own code) so I think we should reroute this together with a Deprecation Warning

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants