Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ddp accelerator choice for cpu #8645

Merged
merged 7 commits into from Aug 2, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Fixes ddp accelerator choice for cpu

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 added bug Something isn't working priority: 0 High priority task labels Jul 30, 2021
@kaushikb11 kaushikb11 added this to the v1.4.x milestone Jul 30, 2021
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #8645 (2c78b61) into master (850416f) will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #8645   +/-   ##
======================================
  Coverage      88%     89%           
======================================
  Files         168     167    -1     
  Lines       13985   13966   -19     
======================================
+ Hits        12355   12393   +38     
+ Misses       1630    1573   -57     

@mergify mergify bot added the ready PRs ready to be merged label Jul 30, 2021
@SeanNaren SeanNaren enabled auto-merge (squash) July 30, 2021 14:56
@kaushikb11 kaushikb11 force-pushed the fix/ddp_for_cpu branch 2 times, most recently from 2309792 to 89613db Compare August 2, 2021 10:18
@pep8speaks
Copy link

pep8speaks commented Aug 2, 2021

Hello @kaushikb11! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-08-02 16:54:15 UTC

@SeanNaren SeanNaren merged commit d01d833 into Lightning-AI:master Aug 2, 2021
awaelchli pushed a commit that referenced this pull request Aug 3, 2021
* Fix ddp accelerator choice for cpu
awaelchli pushed a commit that referenced this pull request Aug 3, 2021
* Fix ddp accelerator choice for cpu
lexierule pushed a commit that referenced this pull request Aug 3, 2021
* Fix ddp accelerator choice for cpu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants