Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple optimizer restart with fault-tolerant training #9537

Merged
merged 21 commits into from Sep 16, 2021

Conversation

awaelchli
Copy link
Member

@awaelchli awaelchli commented Sep 15, 2021

What does this PR do?

Adds necessary changes and tests for restarting a run that failed at a training_step when multiple optimizers are involved. Note: if the user has interactions between the different training_step calls during the loop over the optimizers, this will not work or silently lead to different results, as it is the case with all other places were fault-tolerant takes place.

Part of #9130

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 馃檭

@awaelchli awaelchli force-pushed the feature/multi-optimizer-restart branch from e9b7593 to 1af5368 Compare September 15, 2021 11:43
@awaelchli awaelchli added the feature Is an improvement or enhancement label Sep 15, 2021
@awaelchli awaelchli added this to the v1.5 milestone Sep 15, 2021
tests/loops/test_loops.py Outdated Show resolved Hide resolved
tests/loops/test_loops.py Show resolved Hide resolved
tests/loops/test_loops.py Outdated Show resolved Hide resolved
tests/loops/test_loops.py Outdated Show resolved Hide resolved
tests/loops/test_loops.py Outdated Show resolved Hide resolved
tests/loops/test_loops.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/optimization/optimizer_loop.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the has conflicts label Sep 15, 2021
Copy link
Member

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殌

tests/loops/optimization/test_optimizer_loop.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #9537 (b37730b) into master (5a846d4) will decrease coverage by 0%.
The diff coverage is 67%.

@@          Coverage Diff           @@
##           master   #9537   +/-   ##
======================================
- Coverage      93%     93%   -0%     
======================================
  Files         180     180           
  Lines       15090   15092    +2     
======================================
+ Hits        14019   14020    +1     
- Misses       1071    1072    +1     

@tchaton tchaton enabled auto-merge (squash) September 16, 2021 08:32
@tchaton tchaton merged commit b845414 into master Sep 16, 2021
@tchaton tchaton deleted the feature/multi-optimizer-restart branch September 16, 2021 09:55
@awaelchli awaelchli mentioned this pull request Sep 17, 2021
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants