Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Add auto_restart for fault tolerant training #9722

Merged
merged 44 commits into from Oct 1, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Sep 27, 2021

What does this PR do?

Once a signal.SIGUSR1 is being sent to Lightning, the Trainer should exit to the next most reproducible place. The Trainer would be aware of this as _terminate_gracefully would be equal to True.

This PR adds the following:

  • Logic to the exit the loops using an ExitGracefullyException exception once safe places are reached
  • Save a fault tolerant checkpoint
  • Automatically reload the fault tolerant checkpoint if .pl_auto_save.ckpt files exists.

Part of #9130

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Sep 27, 2021
@tchaton tchaton added this to the v1.5 milestone Sep 27, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #9722 (5c9d28d) into master (60d4cc4) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9722    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         177     177            
  Lines       15390   15514   +124     
=======================================
- Hits        14264   13751   -513     
- Misses       1126    1763   +637     

tests/conftest.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/epoch/training_epoch_loop.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/epoch/evaluation_epoch_loop.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/fit_loop.py Outdated Show resolved Hide resolved
tests/loops/test_loops.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/epoch/training_epoch_loop.py Outdated Show resolved Hide resolved
pytorch_lightning/loops/epoch/evaluation_epoch_loop.py Outdated Show resolved Hide resolved
@mergify mergify bot removed the ready PRs ready to be merged label Sep 30, 2021
@tchaton tchaton requested a review from carmocca October 1, 2021 09:03
@mergify mergify bot added the ready PRs ready to be merged label Oct 1, 2021
@carmocca carmocca enabled auto-merge (squash) October 1, 2021 13:50
@carmocca carmocca merged commit 5841ca9 into master Oct 1, 2021
@carmocca carmocca deleted the fault_tolerant_restart branch October 1, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fault tolerance ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants