Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate log_gpu_memory, gpu_metrics, and util funcs in favor of DeviceStatsMonitor callback #9921

Merged
merged 13 commits into from Oct 14, 2021
Merged

Deprecate log_gpu_memory, gpu_metrics, and util funcs in favor of DeviceStatsMonitor callback #9921

merged 13 commits into from Oct 14, 2021

Conversation

daniellepintz
Copy link
Contributor

@daniellepintz daniellepintz commented Oct 14, 2021 •
edited by carmocca

What does this PR do?

Deprecate log_gpu_memory from Trainer constructor, deprecate gpu_metrics from LoggerConnector, and deprecate some util functions from utilities/memory.py.

These are all replaced by the DeviceStatsCallback which calls get_device_stats on the Accelerator interface #9712

Part of #9032

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 14, 2021 •
edited

Codecov Report

Merging #9921 (d6dabc2) into master (6feda08) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #9921    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         179     179            
  Lines       15805   15808     +3     
=======================================
- Hits        14648   14030   -618     
- Misses       1157    1778   +621

@daniellepintz daniellepintz changed the title Deprecate log_gpu_memory, gpu_metrics, and util funcs Deprecate log_gpu_memory, gpu_metrics, and util funcs in favor of DeviceStatsMonitor callback Oct 14, 2021
@daniellepintz daniellepintz changed the title Deprecate log_gpu_memory, gpu_metrics, and util funcs in favor of DeviceStatsMonitor callback Deprecate log_gpu_memory, gpu_metrics, and util funcs in favor of DeviceStatsMonitor callback Oct 14, 2021
@daniellepintz daniellepintz mentioned this pull request Oct 14, 2021
Closed
12 tasks
tchaton
tchaton approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Oct 14, 2021
kaushikb11
kaushikb11 approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kaushikb11 and others added 3 commits October 14, 2021 18:22
@kaushikb11
Update pytorch_lightning/trainer/connectors/logger_connector/logger_c…
f820c87 
…onnector.py
@kaushikb11 @rohitgr7
Update docs/source/common/trainer.rst
1ef539a 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@kaushikb11 @rohitgr7
Update pytorch_lightning/trainer/connectors/logger_connector/logger_c…
f9cf194 
…onnector.py

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@kaushikb11 @rohitgr7
Update tests/deprecated_api/test_remove_1-7.py
616ff13 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@rohitgr7 rohitgr7 enabled auto-merge (squash) October 14, 2021 12:56
@mergify mergify bot removed the has conflicts label Oct 14, 2021
@carmocca carmocca merged commit 16213b1 into Lightning-AI:master Oct 14, 2021
@carmocca carmocca added this to the v1.5 milestone Oct 14, 2021
@carmocca carmocca added design Includes a design discussion callback deprecation Includes a deprecation labels Oct 14, 2021
@daniellepintz daniellepintz deleted the dep_log_gpu branch October 14, 2021 20:48
@carmocca carmocca mentioned this pull request Oct 15, 2021
Merged
9 tasks
rohitgr7 added a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
@daniellepintz @kaushikb11 @rohitgr7
Deprecate log_gpu_memory, gpu_metrics, and util funcs in favor of…
ba2efa2 
… `DeviceStatsMonitor` callback (Lightning-AI#9921)

Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@akihironitta akihironitta mentioned this pull request Nov 10, 2022
Merged
12 tasks
@Borda Borda mentioned this pull request Mar 10, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carmocca carmocca carmocca approved these changes

@tchaton tchaton tchaton approved these changes

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli is a code owner

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees
No one assigned
Labels
callback deprecation Includes a deprecation design Includes a design discussion ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@daniellepintz @carmocca @tchaton @SkafteNicki @rohitgr7 @kaushikb11