Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate.py and generate/full.py could be merged #313

Open
carmocca opened this issue May 22, 2023 · 4 comments
Open

generate.py and generate/full.py could be merged #313

carmocca opened this issue May 22, 2023 · 4 comments
Labels

Comments

@carmocca
Copy link
Contributor

Proposed in #255

The only difference in logic is the instruction tuning. We could add a flag for it as in #278

@pavanpvl
Copy link

Hi @carmocca
If possible I would like to work on this issue after going through the files and the discussions mentioned above what I can understand is as follows

  1. Remove the generate.py file and add the required changes to the generate/full.py file
  2. Add instruction tuning flag and use generate_prompt function if the flag is true
  3. I can see that generate function in generate.py is referenced in multiple scripts(finetune, evaluate & generate) it can be moved to lit_llama/utils

Let me know if these changes sound good :D

@rasbt
Copy link
Contributor

rasbt commented May 28, 2023

That's a good point. I also wondered if we even needed a generate.py script in the top level. Like you suggest, I am in favor of having the script under generate/ similar to the finetune/ and evaluate/ scripts.

I can see that generate function in generate.py is referenced in multiple scripts(finetune, evaluate & generate) it can be moved to lit_llama/utils

Or could we just reference the respective generate/* scripts then?

@pavanpvl
Copy link

@rasbt Yeah this sounds good as well, I was thinking of having it under utils but it might just be a matter of preference I guess 😅

@ruoyu61
Copy link

ruoyu61 commented Jul 26, 2023

@carmocca I made a PR for this issue.

Could you help to review the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants