Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LogCosh Error #1316

Merged
merged 8 commits into from Nov 8, 2022
Merged

Add LogCosh Error #1316

merged 8 commits into from Nov 8, 2022

Conversation

stancld
Copy link
Contributor

@stancld stancld commented Nov 6, 2022

What does this PR do?

Fixes #1315

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@stancld stancld added this to the v0.11 milestone Nov 6, 2022
@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #1316 (13d7e62) into master (a3dc40c) will decrease coverage by 50%.
The diff coverage is 98%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1316     +/-   ##
========================================
- Coverage      87%     37%    -50%     
========================================
  Files         193     195      +2     
  Lines       11297   11346     +49     
========================================
- Hits         9790    4198   -5592     
- Misses       1507    7148   +5641     

Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :]
Really great work :)

@mergify mergify bot added the ready label Nov 6, 2022
@SkafteNicki SkafteNicki enabled auto-merge (squash) November 8, 2022 10:54
@SkafteNicki SkafteNicki merged commit 920fe0f into master Nov 8, 2022
@SkafteNicki SkafteNicki deleted the metric/log-cosh-error branch November 8, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add LogCoshError metric
3 participants