Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postfix arg to MetricCollection #188

Merged
merged 12 commits into from Apr 20, 2021
Merged

Add postfix arg to MetricCollection #188

merged 12 commits into from Apr 20, 2021

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Apr 20, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #168
Adds a postfix arg that behaves similar to the prefix arg in metric collection.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@SkafteNicki SkafteNicki added the enhancement New feature or request label Apr 20, 2021
@SkafteNicki SkafteNicki added this to the v0.4 milestone Apr 20, 2021
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #188 (2ecd19d) into master (c1ae5ac) will increase coverage by 0.02%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   96.05%   96.08%   +0.02%     
==========================================
  Files         180       90      -90     
  Lines        5760     2886    -2874     
==========================================
- Hits         5533     2773    -2760     
+ Misses        227      113     -114     
Flag Coverage Δ
Linux 79.31% <66.66%> (-0.03%) ⬇️
Windows 79.31% <66.66%> (-0.03%) ⬇️
cpu 96.08% <94.44%> (+<0.01%) ⬆️
gpu ?
macOS 96.08% <94.44%> (+<0.01%) ⬆️
pytest 96.08% <94.44%> (+0.02%) ⬆️
python3.6 96.00% <94.44%> (+<0.01%) ⬆️
python3.8 96.01% <94.44%> (+<0.01%) ⬆️
python3.9 95.91% <94.44%> (+<0.01%) ⬆️
torch1.3.1 94.85% <94.44%> (+0.01%) ⬆️
torch1.4.0 94.97% <94.44%> (+0.01%) ⬆️
torch1.8.1 95.91% <94.44%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
torchmetrics/collections.py 96.96% <94.44%> (+0.30%) ⬆️
...chmetrics/functional/classification/stat_scores.py
.../s/torchmetrics/classification/confusion_matrix.py
__w/2/s/torchmetrics/classification/f_beta.py
__w/2/s/torchmetrics/functional/regression/psnr.py
__w/2/s/torchmetrics/classification/auc.py
__w/2/s/torchmetrics/setup_tools.py
__w/2/s/torchmetrics/classification/stat_scores.py
...torchmetrics/functional/classification/__init__.py
__w/2/s/torchmetrics/average.py
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1ae5ac...2ecd19d. Read the comment docs.

CHANGELOG.md Outdated Show resolved Hide resolved
@SkafteNicki SkafteNicki modified the milestones: v0.4, v0.3 Apr 20, 2021
@Borda Borda enabled auto-merge (squash) April 20, 2021 15:26
tests/bases/test_collections.py Outdated Show resolved Hide resolved
tests/bases/test_collections.py Outdated Show resolved Hide resolved
torchmetrics/collections.py Outdated Show resolved Hide resolved
torchmetrics/collections.py Outdated Show resolved Hide resolved
torchmetrics/collections.py Outdated Show resolved Hide resolved
torchmetrics/collections.py Outdated Show resolved Hide resolved
@Borda Borda added the ready label Apr 20, 2021
torchmetrics/collections.py Outdated Show resolved Hide resolved
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@Borda Borda merged commit 1aab672 into master Apr 20, 2021
@Borda Borda deleted the postfix_collection branch April 20, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postfix arg for MetricCollection.clone in order to support TensorBoard grouping
4 participants