New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add postfix arg to MetricCollection #188
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
ananyahjha93,
Borda,
justusschock and
tchaton
as code owners
April 20, 2021 12:53
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
+ Coverage 96.05% 96.08% +0.02%
==========================================
Files 180 90 -90
Lines 5760 2886 -2874
==========================================
- Hits 5533 2773 -2760
+ Misses 227 113 -114
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Borda
reviewed
Apr 20, 2021
…ing/metrics into postfix_collection
Borda
approved these changes
Apr 20, 2021
awaelchli
approved these changes
Apr 20, 2021
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
justusschock
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
Fixes #168
Adds a
postfix
arg that behaves similar to theprefix
arg in metric collection.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃