Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt find_unused_parameters warning #12445

Closed
carmocca opened this issue Mar 24, 2022 · 1 comment · Fixed by #16611 or #16646
Closed

Adapt find_unused_parameters warning #12445

carmocca opened this issue Mar 24, 2022 · 1 comment · Fixed by #16611 or #16646
Labels
3rd party Related to a 3rd-party performance

Comments

@carmocca
Copy link
Member

carmocca commented Mar 24, 2022

🚀 Feature

Latter PyTorch versions introduced the following warning

https://github.com/pytorch/pytorch/blob/d0adb5ff264df8e0e057ce1178feb30198c601d2/torch/csrc/distributed/c10d/reducer.cpp#L1256-L1264

which appears when find_unused_parameters=True but it's not necessary.

Motivation

We set find_unused_parameters=True by default, so this warning will appear for a large percentage of users.

Pitch

Catch this warning and produce another one that explicitly mentions how to modify the strategy passed.


If you enjoy Lightning, check out our other projects! ⚡

  • Metrics: Machine learning metrics for distributed, scalable PyTorch applications.

  • Lite: enables pure PyTorch users to scale their existing code on any kind of device while retaining full control over their own loops and optimization logic.

  • Flash: The fastest way to get a Lightning baseline! A collection of tasks for fast prototyping, baselining, fine-tuning, and solving problems with deep learning.

  • Bolts: Pretrained SOTA Deep Learning models, callbacks, and more for research and production with PyTorch Lightning and PyTorch.

  • Lightning Transformers: Flexible interface for high-performance research using SOTA Transformers leveraging Pytorch Lightning, Transformers, and Hydra.

cc @Borda @akihironitta

@carmocca carmocca added 3rd party Related to a 3rd-party performance labels Mar 24, 2022
@carmocca carmocca added this to the 1.7 milestone Apr 12, 2022
@carmocca
Copy link
Member Author

This is blocked by pytorch/pytorch#75725

@carmocca carmocca modified the milestones: pl:1.7, pl:future Jul 19, 2022
@carmocca carmocca removed this from the future milestone Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party performance
Projects
No open projects
Status: Done
2 participants