Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics: AUC #1296

Closed
justusschock opened this issue Mar 30, 2020 · 3 comments 路 Fixed by #1488 or #1327
Closed

Metrics: AUC #1296

justusschock opened this issue Mar 30, 2020 · 3 comments 路 Fixed by #1488 or #1327
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Projects
Metrics package
Milestone
pl:0.8

Comments

@justusschock
Copy link
Member

馃殌 Feature

Implement general AUC (to be combined with other metrics like ROC)
@justusschock justusschock added feature Is an improvement or enhancement help wanted Open to be worked on labels Mar 30, 2020
@Borda Borda added this to To do in Metrics package Mar 30, 2020
@Borda Borda changed the title [Metrics Package] AUC Metrics: AUC Mar 30, 2020
@nickyi1990
Copy link

just use from sklearn.metrics import roc_auc_score, I don't think there's any need to write this function from scratch

@justusschock
Copy link
Member Author

Actually there is. Using the sklearn function involves the necessity to convert from torch.Tensor to numpy.ndarray before converting. While this is totally fine on cpu (no memory copy made here), this really causes a slow-down for gpu tensors, since it involves a GPU-sync.
For now #1327 already implements a sklearn version, but it shall be replaced with a native torch one.

@williamFalcon williamFalcon added this to the Metrics milestone May 19, 2020
@Borda Borda modified the milestones: Metrics, 0.8.0 May 26, 2020
This was referenced Jun 9, 2020
Merged
Merged
Metrics package automation moved this from To do to Done Jun 10, 2020
@justusschock
Copy link
Member Author

@Borda I reopened this, since this is meant for native implementations in #1488

@justusschock justusschock reopened this Jun 10, 2020
Metrics package automation moved this from Done to in Progress Jun 10, 2020
Metrics package automation moved this from in Progress to Done Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Is an improvement or enhancement help wanted Open to be worked on
Projects
No open projects
Metrics package
  
Done
Milestone
pl:0.8
4 participants
@williamFalcon @Borda @justusschock @nickyi1990