Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total time in Simpleprofiler does not add up to the function run-times #15334

Open
Abhishaike opened this issue Oct 26, 2022 · 3 comments
Open
Labels
profiler question Further information is requested won't fix This will not be worked on

Comments

@Abhishaike
Copy link

Abhishaike commented Oct 26, 2022

Bug description

Used the SimpleProfiler while training a model with DDP, and found that the constituent times of the functions did not add up to the total. Is this a bug?

Alternatively, do these calls each represent one GPU's worth of profiling? Like, should I multiply each of the function calls by my number of GPU's (4 in this case) to get a better estimate?

Alternatively alternatively, should I view the bulk of the 'total time' as the 'cost' of the DDP spin-up? If so, should this be documented somewhere?

Screen Shot 2022-10-26 at 11 49 35 AM

cc @carmocca @kaushikb11 @ninginthecloud @rohitgr7 @nbcsm @guotuofeng

@Abhishaike Abhishaike added the needs triage Waiting to be triaged by maintainers label Oct 26, 2022
@rohitgr7
Copy link
Contributor

they won't add up because some of them includes the time of other method calls. For eg: run_training_batch is part of run_training_epoch.

@Abhishaike
Copy link
Author

This makes sense, but there nevertheless is a massive discrepancy between any given time and the total time

@carmocca carmocca added question Further information is requested profiler and removed needs triage Waiting to be triaged by maintainers labels Nov 3, 2022
@stale
Copy link

stale bot commented Apr 14, 2023

This issue has been automatically marked as stale because it hasn't had any recent activity. This issue will be closed in 7 days if no further activity occurs. Thank you for your contributions - the Lightning Team!

@stale stale bot added the won't fix This will not be worked on label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profiler question Further information is requested won't fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants