Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastAPI Version Seems to Cause Issue #17277

Closed
fishbotics opened this issue Apr 4, 2023 · 1 comment · Fixed by #17173
Closed

FastAPI Version Seems to Cause Issue #17277

fishbotics opened this issue Apr 4, 2023 · 1 comment · Fixed by #17173
Labels
app Generic label for Lightning App package bug Something isn't working help wanted Open to be worked on priority: 0 High priority task ver: 2.0.x
Milestone

Comments

@fishbotics
Copy link

fishbotics commented Apr 4, 2023

Bug description

I am getting an issue from FastAPI, which is installed as a dependency.

image

As shown in the photo, I have fastapi 0.88.0. When I upgrade to 0.95 (the latest version), this error goes away. But, pip complains because Lightning is pinned to this version of FastAPI.

Would it be possible to update the dependency?

FWIW there is a similar issue on the FastAPI Github: tiangolo/fastapi#5977

They fixed it by updating Starlette, but I think I'm already on the newest version.

What version are you seeing the problem on?

2.0+

How to reproduce the bug

No response

Error messages and logs

# Error messages and logs here please

Environment

Current environment
#- Lightning Component (e.g. Trainer, LightningModule, LightningApp, LightningWork, LightningFlow):
#- PyTorch Lightning Version (e.g., 1.5.0):
#- Lightning App Version (e.g., 0.5.2):
#- PyTorch Version (e.g., 2.0):
#- Python version (e.g., 3.9):
#- OS (e.g., Linux):
#- CUDA/cuDNN version:
#- GPU models and configuration:
#- How you installed Lightning(`conda`, `pip`, source):
#- Running environment of LightningApp (e.g. local, cloud):

More info

No response

cc @tchaton

@fishbotics fishbotics added bug Something isn't working needs triage Waiting to be triaged by maintainers labels Apr 4, 2023
@awaelchli
Copy link
Member

Would it be possible to update the dependency?

I think so yes! Let's try it. The file here needs to be updated by bumping the version there to the latest: https://github.com/Lightning-AI/lightning/blob/6cbc9dfb9174ec38909a3d0e46f584ce109777cf/requirements/app/base.txt#L15

The fastapi has a "strict" label since something was broken there. We can backtrack through git-blame why this was set and check whether the issue was resolved in newer versions. If so, we can do this: fastapi!=0.89.0

@awaelchli awaelchli added help wanted Open to be worked on priority: 0 High priority task app Generic label for Lightning App package and removed needs triage Waiting to be triaged by maintainers labels Apr 4, 2023
@awaelchli awaelchli added this to the 2.0.x milestone Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Generic label for Lightning App package bug Something isn't working help wanted Open to be worked on priority: 0 High priority task ver: 2.0.x
Projects
None yet
3 participants