Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate *_percent_check for each *_dataloader #1964

Closed
rohitgr7 opened this issue May 26, 2020 · 4 comments
Closed

Separate *_percent_check for each *_dataloader #1964

rohitgr7 opened this issue May 26, 2020 · 4 comments
Labels
discussion In a discussion stage feature Is an improvement or enhancement help wanted Open to be worked on won't fix This will not be worked on

Comments

@rohitgr7
Copy link
Contributor

🚀 Feature

Can we have *_percent_check to be a list too where len(*_percent_check) == len(*_dataloaders)? In case if it is int then it will be same for all the dataloaders passed. Don't know how this can be useful in any case, just a thought.

Motivation

Pitch

For each val_dataloader or test_dataloader we can have an option to pass *_percent_check as a list with a percent_check for each of the dataloader. For eg. val_percent_check = [0.1, 0.4] and val_dataloaders = [val_dl1, val_dl2].

Alternatives

Additional context

Later we can do the same for training as well if #1959 get's merged.

@rohitgr7 rohitgr7 added feature Is an improvement or enhancement help wanted Open to be worked on labels May 26, 2020
@rohitgr7 rohitgr7 changed the title Separate *_percent_check for each *_dataloader Separate *_percent_check for each *_dataloader May 26, 2020
@awaelchli
Copy link
Member

Your proposal is definitely feasible, but I'm not sure what the use case for this would be. Currently the *_percent_check args are intented to be used for debugging purposes, e.g. trying to overfit to make sure the model has the capacity, in which case a separation into multiple sizes is not needed.

Could be a follow up to your existing PR #1920
@PyTorchLightning/core-contributors

@Borda Borda added the discussion In a discussion stage label May 28, 2020
@stale
Copy link

stale bot commented Jul 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Jul 27, 2020
@Borda Borda removed the won't fix This will not be worked on label Jul 27, 2020
@stale
Copy link

stale bot commented Sep 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Sep 25, 2020
@rohitgr7
Copy link
Contributor Author

looks like not a useful feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion In a discussion stage feature Is an improvement or enhancement help wanted Open to be worked on won't fix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants