Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matthews correlation coefficient should return 0 instead of NaN #779

Closed
tridao opened this issue Jan 18, 2022 · 1 comment 路 Fixed by #781
Closed

Matthews correlation coefficient should return 0 instead of NaN #779

tridao opened this issue Jan 18, 2022 · 1 comment 路 Fixed by #781
Labels
bug / fix Something isn't working help wanted Extra attention is needed

Comments

@tridao
Copy link
Contributor

tridao commented Jan 18, 2022

馃悰 Bug

By definition, "if any of the four sums in the denominator is zero, the denominator can be arbitrarily set to one; this results in a Matthews correlation coefficient of zero, which can be shown to be the correct limiting value."
However, the code does not check for this case and will return NaN.

@tridao tridao added bug / fix Something isn't working help wanted Extra attention is needed labels Jan 18, 2022
@github-actions
Copy link

Hi! thanks for your contribution!, great first issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant