Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add classification metrics: SensitivityAtSpecificity and SpecificityAtSensitivity #971

Closed
iamharsha1999 opened this issue Apr 20, 2022 Discussed in #965 · 10 comments · Fixed by #1432
Closed

Add classification metrics: SensitivityAtSpecificity and SpecificityAtSensitivity #971

iamharsha1999 opened this issue Apr 20, 2022 Discussed in #965 · 10 comments · Fixed by #1432
Assignees
Labels
enhancement New feature or request New metric
Milestone

Comments

@iamharsha1999
Copy link

Discussed in #965

Originally posted by iamharsha1999 April 19, 2022
I was specifically looking for the following two metrics:

  1. Sensitivity at Specificity
  2. Specificity at Sensitivity

However I was not able to find it ? Would it be possible to add these implementations to torchmetrics.

You can find the tensorflow implementations below:
https://www.tensorflow.org/api_docs/python/tf/keras/metrics/SpecificityAtSensitivity
https://www.tensorflow.org/api_docs/python/tf/keras/metrics/SensitivityAtSpecificity

@github-actions
Copy link

Hi! thanks for your contribution!, great first issue!

@stancld stancld added New metric enhancement New feature or request labels Apr 21, 2022
@stancld stancld changed the title Metrics Missing (Classification) Add classification metrics: SensitivityAtSpecificity and SpecificityAtSensitivity Apr 22, 2022
@SkafteNicki
Copy link
Member

Hi @iamharsha1999,
You are completely right that these metrics are not implemented in torchmetrics, yet ;)
Would you like to contribute them to the project?

@iamharsha1999
Copy link
Author

iamharsha1999 commented Apr 25, 2022

@SkafteNicki Hey Sure! I'd like to try it out.

@angadkalra
Copy link

Any progress on this? I actually implemented this metric for my own project and can contribute if needed.

@iamharsha1999
Copy link
Author

Any progress on this? I actually implemented this metric for my own project and can contribute if needed.

Hey kindly,
Go ahead and contribute. I can jump in later. Have been busy with work lately.

@SkafteNicki SkafteNicki added this to the v0.11 milestone Sep 2, 2022
@SkafteNicki SkafteNicki added this to To do in Classification refactor via automation Sep 2, 2022
@stancld
Copy link
Contributor

stancld commented Sep 8, 2022

Hi @angadkalra, do you have any updates here? :]

@Borda Borda modified the milestones: v0.11, v0.12 Nov 9, 2022
@angadkalra
Copy link

Sorry for the late reply! I will contribute ASAP.

@iamharsha1999
Copy link
Author

@angadkalra @SkafteNicki Hey any update on this issue. I can try this out and contribute.

@angadkalra
Copy link

@iamharsha1999 go ahead, I'm busy with work as well.

@shenoynikhil
Copy link
Contributor

shenoynikhil commented Jan 7, 2023

I had a draft local branch on this a while back. Just put it up since there had been no update on this. Feel free to implement the other variant SensitivityAtSpecificity if you guys are interested.

Classification refactor automation moved this from To do to Done Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request New metric
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants