Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

Export Prometheus Metrics #70

Open
alecmerdler opened this issue Oct 19, 2022 · 3 comments
Open

Export Prometheus Metrics #70

alecmerdler opened this issue Oct 19, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@alecmerdler
Copy link
Contributor

Description

Use the Prometheus Python client to export metrics for monitoring the performance of Echo, which will be especially useful when running at scale in a multi-tenant environment (https://lightning.ai/echo).

Some metrics could include:

  • Number of processing Echoes
  • Total number of completed Echoes
  • Current number of Recognizer/YouTuber Works running
  • etc...
@manskx
Copy link

manskx commented Oct 25, 2022

@alecmerdler If we create a route in configure_api() that exposes the needed metrics, would this be useful?

@alecmerdler
Copy link
Contributor Author

@manskx I considered and half-implemented a /metrics endpoint which queried the database for some basic information, but I realized that we get a lot more value by adding Prometheus properly (Grafana, per-node metrics, FastAPI integration, etc). Let's just commit to Prometheus: the client looks easy enough to adopt and we can start with basic metrics and always expand later.

@tchaton
Copy link
Contributor

tchaton commented Oct 25, 2022

@alecmerdler I was using this one: https://github.com/trallnag/prometheus-fastapi-instrumentator and started to build Prometheus and Graphana works, but we need to install python within their images, so the work can start.

@alecmerdler alecmerdler added the enhancement New feature or request label Oct 28, 2022
@alecmerdler alecmerdler added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 28, 2022
@Borda Borda assigned alecmerdler and unassigned manskx Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants