Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type annotations #434

Open
1 of 17 tasks
akihironitta opened this issue Dec 8, 2020 · 15 comments
Open
1 of 17 tasks

Add type annotations #434

akihironitta opened this issue Dec 8, 2020 · 15 comments
Labels
enhancement New feature or request

Comments

@akihironitta
Copy link
Contributor

akihironitta commented Dec 8, 2020

馃殌 Feature

As static type checker mypy was added in #433, we can add type annotations to the codebase.

Steps to contribute

For each PR:

  1. choose and remove one submodule from the list below
  2. add type hints the submodule you chose
  3. make sure to pass mypy check with mypy

Progress

@akihironitta akihironitta added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 8, 2020
@akihironitta akihironitta added this to To do in Code Health / Refatoring via automation Dec 8, 2020
@akihironitta akihironitta changed the title Add type annotations to the codebase Add type annotations Dec 8, 2020
@hassiahk
Copy link
Contributor

Any help needed with this issue? I am happy to help. 馃槃

@akihironitta akihironitta self-assigned this Dec 15, 2020
@akihironitta
Copy link
Contributor Author

@hassiahk Yes! I just added the steps to contribute to the above comment, so it'd be great if you follow them and submit a PR! :]

@hassiahk

This comment has been minimized.

@akihironitta

This comment has been minimized.

@hassiahk

This comment has been minimized.

@akihironitta

This comment has been minimized.

@briankosw
Copy link
Contributor

briankosw commented Dec 17, 2020

Hey @akihironitta, I'd love to help with this :) Should I just pick one and create a PR?

@akihironitta
Copy link
Contributor Author

@briankosw Yes! Thank you!

@hassiahk
Copy link
Contributor

hassiahk commented Dec 18, 2020

Hey @briankosw. Yes, you can pick one and create a PR for it. 馃槃 Just leave a comment here saying you picked up this submodule, so you won't clash with others.

@briankosw
Copy link
Contributor

I guess I'll work on pl_bolts.datamodules then!

@hassiahk
Copy link
Contributor

hassiahk commented Dec 22, 2020

@akihironitta, I will be working on pl_bolts.losses next. :)

@johnpeterson123
Copy link

I'm going to work on pl_bolts.optimizers now!

@akihironitta
Copy link
Contributor Author

@johnpeterson123 Thank you for your contribution!

@jeromepatel
Copy link
Contributor

I am interested in working on pl_bolts.models.regression.* .

@akihironitta
Copy link
Contributor Author

Not sure if we want to continue on this issue because there will be a lot of # type: ignore comments in the codebase (like in #444 and #608), which I think lowers readability. Should we still keep adding type hints to Bolts?

@akihironitta akihironitta removed their assignment Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

5 participants