Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytorch_lightning.loggers import LightningLoggerBase #972

Closed
zxkathy opened this issue Feb 4, 2023 · 3 comments · Fixed by #973
Closed

pytorch_lightning.loggers import LightningLoggerBase #972

zxkathy opened this issue Feb 4, 2023 · 3 comments · Fixed by #973
Labels
help wanted Extra attention is needed

Comments

@zxkathy
Copy link

zxkathy commented Feb 4, 2023

In data_monitor.py

pytorch_lightning.loggers import LightningLoggerBase

I always get the error message cannot import name 'LightningLoggerBase' from 'pytorch_lightning.loggers'

but would be working if

from pytorch_lightning.loggers.base import LightningLoggerBase

Or if you update latest pytorch_lightning, they removed LightningLoggerBase completely, and use something else simpler.

@zxkathy zxkathy added the help wanted Extra attention is needed label Feb 4, 2023
@senarvi
Copy link
Contributor

senarvi commented Feb 24, 2023

This is a duplicate of #962

@devdastl
Copy link

Is this issue solved? I can still see LightningModule in data_monitor.py

@tedtroxell
Copy link

@devdastl there's a PR that's been out for a little bit. I'm hoping that we can get it merged ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants