Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when running on unsupported platforms #32

Closed
LilithHafner opened this issue Mar 11, 2024 · 0 comments · Fixed by #38
Closed

Warn when running on unsupported platforms #32

LilithHafner opened this issue Mar 11, 2024 · 0 comments · Fixed by #38

Comments

@LilithHafner
Copy link
Owner

This CI run using Ubuntu & Julia 1.6 had these logs

   Testing Chairmarks
      Status `/tmp/jl_aHcgtG/Project.toml`
  [4c88cf16] Aqua v0.8.4
  [0ca39b1e] Chairmarks v1.1.2 `~/work/Chairmarks.jl/Chairmarks.jl`
  [2cca1867] RegressionTests v0.0.5
  [de0858da] Printf `@stdlib/Printf`
  [10745b16] Statistics `@stdlib/Statistics`
  [8dfed614] Test `@stdlib/Test`
      Status `/tmp/jl_aHcgtG/Manifest.toml`
  [4c88cf16] Aqua v0.8.4
  [0ca39b1e] Chairmarks v1.1.2 `~/work/Chairmarks.jl/Chairmarks.jl`
  [34da2185] Compat v4.14.0
  [2cca1867] RegressionTests v0.0.5
   [17] macro expansion
      @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
   [18] macro expansion
      @ ~/work/Chairmarks.jl/Chairmarks.jl/test/runtests.jl:351 [inlined]
   [19] macro expansion
      @ /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
   [20] top-level scope
      @ ~/work/Chairmarks.jl/Chairmarks.jl/test/runtests.jl:6
   [21] include(fname::String)
      @ Base.MainInclude ./client.jl:444
   [22] top-level scope
      @ none:6
   [23] eval
      @ ./boot.jl:360 [inlined]
   [24] exec_options(opts::Base.JLOptions)
      @ Base ./client.jl:261
   [25] _start()
      @ Base ./client.jl:485
Test Summary:          |   Pass  Error  Broken   Total
Chairmarks             | 754072      1       3  754076
  Standard tests       | 754046                 754046
  Statistics Extension |      2                      2
  Precision            |     14              2      16
  Performance          |                     1       1
  Aqua                 |     10                     10
  Regression Tests     |             1               1
ERROR: LoadError: Some tests did not pass: 754072 passed, 0 failed, 1 errored, 3 broken.
in expression starting at /home/runner/work/Chairmarks.jl/Chairmarks.jl/test/runtests.jl:5
ERROR: LoadError: Package Chairmarks errored during testing
Stacktrace:
 [1] pkgerror(msg::String)
   @ Pkg.Types /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Pkg/src/Types.jl:55
 [2] test(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}; coverage::Bool, julia_args::Cmd, test_args::Cmd, test_fn::Nothing)
   @ Pkg.Operations /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Pkg/src/Operations.jl:1712
 [3] test(ctx::Pkg.Types.Context, pkgs::Vector{Pkg.Types.PackageSpec}; coverage::Bool, test_fn::Nothing, julia_args::Vector{String}, test_args::Cmd, kwargs::Base.Iterators.Pairs{Symbol, IOContext{Base.PipeEndpoint}, Tuple{Symbol}, NamedTuple{(:io,), Tuple{IOContext{Base.PipeEndpoint}}}})
   @ Pkg.API /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:343
 [4] test(pkgs::Vector{Pkg.Types.PackageSpec}; io::IOContext{Base.PipeEndpoint}, kwargs::Base.Iterators.Pairs{Symbol, Any, Tuple{Symbol, Symbol}, NamedTuple{(:coverage, :julia_args), Tuple{Bool, Vector{String}}}})
   @ Pkg.API /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:80
 [5] test(; name::Nothing, uuid::Nothing, version::Nothing, url::Nothing, rev::Nothing, path::Nothing, mode::Pkg.Types.PackageMode, subdir::Nothing, kwargs::Base.Iterators.Pairs{Symbol, Any, Tuple{Symbol, Symbol}, NamedTuple{(:coverage, :julia_args), Tuple{Bool, Vector{String}}}})
   @ Pkg.API /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/Pkg/src/API.jl:96
 [6] top-level scope
   @ ~/work/_actions/julia-actions/julia-runtest/v1/test_harness.jl:15
 [7] include(fname::String)
   @ Base.MainInclude ./client.jl:444
 [8] top-level scope
   @ none:1
in expression starting at /home/runner/work/_actions/julia-actions/julia-runtest/v1/test_harness.jl:7
Error: Process completed with exit code 1.

The problem was that it ran RegressionTests on an unsupported platform. The solution is to pass skip_unsupported_platforms=true. There should be a prominent warning and hint when this happens. It should be easy to implement this as we already check if the platform is supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant