Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update embedded config #188

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix: update embedded config #188

merged 1 commit into from
Jun 25, 2024

Conversation

AquiGorka
Copy link
Contributor

@AquiGorka AquiGorka commented Jun 25, 2024 •
edited
Loading

Review Type Requested (choose one):

  • Glance - superficial check (from domain experts)
  • Logic - thorough check (from everybody doing review)

Summary

This change updates one of the values for the configs.

And the cli run worked!

Screenshot 2024-06-25 at 5 30 14 PM

@github-actions github-actions bot added the fix label Jun 25, 2024
@AquiGorka AquiGorka requested a review from bgins June 25, 2024 20:30
bgins
bgins approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@AquiGorka AquiGorka merged commit 2dde06d into main Jun 25, 2024
2 checks passed
@AquiGorka AquiGorka deleted the gorka/fix-embedded-config branch June 25, 2024 20:52
This was referenced Jul 3, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgins bgins bgins approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AquiGorka @bgins