Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: simply state loop in sc & fix typo #193

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Conversation

hunjixin
Copy link
Contributor

@hunjixin hunjixin commented Jun 26, 2024

Review Type Requested (choose one):

  • Glance - superficial check (from domain experts)
  • Logic - thorough check (from everybody doing review)

this pr is pick pow smart constract's changes from #163

  1. fix typo
  2. simplfy the way to get state in sc
  3. remove a not nessasry api function

Summary

Provide a one line summary and link to any relevant references

Task/Issue reference

Closes: add_link_here

Details (optional)

Add any additional details that might help Code Reviewers digest this PR

How to test this code? (optional)

Anything else? (optional)

Copy link
Contributor

@richardbremner richardbremner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we add the purge function as discussed?

@hunjixin
Copy link
Contributor Author

shall we add the purge function as discussed?

i can add it in another pr if nessary. we can merge this one first.

@hunjixin
Copy link
Contributor Author

@richardbremner can you review again

Copy link
Contributor

@richardbremner richardbremner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approval the content but lets make sure we know how we are releasing the sc changes before doing so

@hunjixin hunjixin merged commit 666cbb6 into main Jun 27, 2024
2 checks passed
@hunjixin hunjixin deleted the feat/simply_pow_contract branch June 27, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants