Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: update cuda algo #219

Merged
merged 4 commits into from
Jul 3, 2024
Merged

perf: update cuda algo #219

merged 4 commits into from
Jul 3, 2024

Conversation

hunjixin
Copy link
Contributor

@hunjixin hunjixin commented Jul 2, 2024

Review Type Requested (choose one):

  • Glance - superficial check (from domain experts)
  • Logic - thorough check (from everybody doing review)

Summary

Provide a one line summary and link to any relevant references

Task/Issue reference

Closes: add_link_here

Details (optional)

Add any additional details that might help Code Reviewers digest this PR

How to test this code? (optional)

Anything else? (optional)

Copy link
Contributor

@richardbremner richardbremner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong with it, but I really don't have enough context of CUDA.

Please make sure you test it works and doesn't cause any errors

@richardbremner richardbremner merged commit 20ad59c into main Jul 3, 2024
2 checks passed
@richardbremner richardbremner deleted the perf/updat_cuda_algo branch July 3, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants