Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement the Error interface #271

Closed
radkomih opened this issue Nov 3, 2023 · 1 comment · Fixed by #295
Closed

implement the Error interface #271

radkomih opened this issue Nov 3, 2023 · 1 comment · Fixed by #295
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@radkomih
Copy link
Collaborator

radkomih commented Nov 3, 2023

There are places where we return values such as for eaxmple (Address32, TransactionValidityError), but there may be other errors that could occur and we might want to propagate them as well. For this reason, we might consider implementing the Error interface for all types that resemble errors (TransactionValidityError, TokenError, etc.).
In certain places, we should check if the error is of the type in which we are interested.

@radkomih radkomih added the enhancement New feature or request label Nov 3, 2023
@radkomih radkomih added the good first issue Good for newcomers label Nov 8, 2023
@tgntr tgntr linked a pull request Nov 21, 2023 that will close this issue
2 tasks
@tgntr
Copy link
Collaborator

tgntr commented Nov 21, 2023

as a next step we could remove Result types (e.g. goscale.Result, DispatchResultWithPostInfo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants