Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API doesn't give a download link while builds are availble #43

Open
Broxzier opened this issue Aug 10, 2019 · 4 comments
Open

API doesn't give a download link while builds are availble #43

Broxzier opened this issue Aug 10, 2019 · 4 comments
Labels

Comments

@Broxzier
Copy link

The update script that I use on my Ubuntu server fetches the last download link from this API call: https://openrct2.org/altapi/?command=get-latest-download&flavourId=9&gitBranch=develop

Normally, it gives back an URL to the last develop download link, but now I get this response:

{
  "error": 1,
  "errorMessage": "No download available."
}

I suspect the reason for not giving back an URL is because a "newer" build is available for another platform, right now that's x86 ZIP and installer: https://openrct2.org/downloads/develop/v0.2.3-d730a76

"newer" is quoted, because the build was probably pushed later, but the build comes from a commit that is from before the the Linux build has finished: https://openrct2.org/downloads/develop/v0.2.3-68dc4d0, meaning that the Linux build is ahead, but doesn't show up under the "latest" build.

I suspect this is also what's causing the Launcher to fail to download updates.

@GingerAdonis
Copy link
Collaborator

GingerAdonis commented Aug 12, 2019

Your assumptions are correct. I'll fix it soon.

@GingerAdonis
Copy link
Collaborator

Note to self: Bug still exists. Should really look into it.

@Basssiiie
Copy link

@GingerAdonis bug still happens. I'd suppose an extra where-clause here to get the latest build with a required flavour present could potentially fix it?

@Broxzier
Copy link
Author

Broxzier commented Apr 1, 2022

That's for the website, but I guess the API works in a similar way. Wouldn't this be fixed by simply giving back the last successful build for the given flavourId and gitBranch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants