Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify the right size for SubtreeSlide #93

Open
walterxie opened this issue Oct 12, 2022 · 2 comments
Open

specify the right size for SubtreeSlide #93

walterxie opened this issue Oct 12, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@walterxie
Copy link
Collaborator

SubtreeSlide should specify size to be about #variable sites / total number of sites.

If it starts too far away it won't get to the good value.
@walterxie walterxie added the enhancement New feature or request label Oct 12, 2022
@walterxie
Copy link
Collaborator Author

walterxie commented Oct 12, 2022 •
edited

LPhyBEAST has already the code to estimate size of subtreeSlide subtreeSlide.setInputValue("size", tree.getRoot().getHeight() / 10.0); , which is suitable for more data types.

@walterxie
Copy link
Collaborator Author

From Alexei:
What if the starting tree is a crap height?
I think that would be slightly better if it was / log(#taxa) rather than / 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@walterxie