Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandpass filter fails with lanczos method #426

Open
CommonClimate opened this issue May 23, 2023 · 0 comments
Open

Bandpass filter fails with lanczos method #426

CommonClimate opened this issue May 23, 2023 · 0 comments
Assignees
Labels

Comments

@CommonClimate
Copy link
Collaborator

Currently only the (default) Butterworth method for filter allows to pass a list of scales/frequencies to obtain a bandpass-filtered series.

ts.filter(method='lanczos',cutoff_scale=[2,8])

returns:
ValueError: Lanczos filter requires a scalar input as cutoff scale/frequency

However, nothing prevents a lowpass filter from being used as a bandpass filter, like so:

ts_hi = ts.filter(method = 'my non_butterworth method', scale = scale_hi)
ts_lo = ts.filter(method = 'my non_butterworth method', scale = scale_lo)
ts_bd = ts_hi - ts_lo

This should be what happens when calling ts.filter(method = 'my non_butterworth method', scale = [scale_hi, scale_lo])

Suggest generalizing so that this option is available to all methods

@CommonClimate CommonClimate added this to the BYOP (PaleoHack 4) milestone May 23, 2023
@CommonClimate CommonClimate self-assigned this May 23, 2023
@khider khider added this to To do (next) in Development status Jun 21, 2023
@khider khider moved this from To do (next) to To do in Development status Aug 25, 2023
@khider khider added the bug label Aug 25, 2023
@khider khider moved this from To do to To do (next) in Development status Aug 25, 2023
@khider khider moved this from To do (next) to To do in Development status Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To do
Development

No branches or pull requests

2 participants