Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"wood" vs "tree" in LiPD #57

Closed
khider opened this issue May 10, 2024 · 7 comments
Closed

"wood" vs "tree" in LiPD #57

khider opened this issue May 10, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@khider
Copy link
Member

khider commented May 10, 2024

The proper vocabulary name for this archiveType is wood per https://lipdverse.org/vocabulary/archivetype/. Therefore, for filtering purposes, one need to use wood as in:

image

However, when using the get_timeseries_essentials method, the archiveType is still tree. This is going to be confusing.

image

I suspect that tree is forced from wood somewhere in the code base.

@khider
Copy link
Member Author

khider commented May 10, 2024

To reproduce, used the Pages2k folder from the tutorials

@khider khider added enhancement New feature or request question Further information is requested labels May 10, 2024
@varunratnakar
Copy link
Contributor

I get the archiveType as "Wood" now.

Screenshot 2024-05-11 at 3 16 48 PM

@khider
Copy link
Member Author

khider commented May 13, 2024

I still don't

image

@varunratnakar
Copy link
Contributor

Screenshot 2024-05-14 at 12 00 22 PM It is still working for me.. Could you paste the whole code that you are running ?

@khider
Copy link
Member Author

khider commented May 14, 2024

It's the one attached to LiPDSeries, sorry, just realized this

@varunratnakar
Copy link
Contributor

Ah ok. So it's the archiveType attached to variables. I've added a parsing step for archiveType at the variable level as well. Please try now.

@khider
Copy link
Member Author

khider commented May 16, 2024

All good!

@khider khider closed this as completed May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Status: Done
Development

No branches or pull requests

2 participants