Swift 3 branch without any API changes #3
Conversation
| @@ -56,7 +57,7 @@ extension ReloadableViewLayoutAdapter: UICollectionViewDataSource { | |||
| arrangement = nil | |||
| assertionFailure("unknown supplementary view kind \(kind)") | |||
| } | |||
| arrangement?.makeViews(inView: view) | |||
| _ = arrangement?.makeViews(inView: view) | |||
There was a problem hiding this comment.
Instead of this, can you mark makeViews as @discardableResult.
|
Cool, thanks for doing this work! I added some comments to the code. Can you also update .travis.yml to run Xcode8 so we can verify that tests pass? Will also need to add/update the destinations appropriately in .travis.yml |
| }; | ||
| name = Release; | ||
| }; | ||
| 0BE47F3C1CC57492003820E8 /* Debug */ = { | ||
| isa = XCBuildConfiguration; | ||
| buildSettings = { | ||
| ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES; |
There was a problem hiding this comment.
Can you explain what this setting does? Does it replace EMBEDDED_CONTENT_CONTAINS_SWIFT?
|
Looking good, can you rebase on master so tests get run? I think there is a merge conflict because I modified .travis.yml in master due to some test flakiness. |
|
Looks like we need to remove iOS 8 & 9 simulator destinations from .travis.yml. Xcode 8 currently only includes iOS 10. |
|
Can you remove |
|
Still fails. Not sure how to deal this issue. |
|
Can you please turn off whole module optimization and also add |
|
None or Fast, Single-File Optimization, which option do you prefer? |
|
And .travis.yml will be changed like this, is it OK? language: objective-c
osx_image: xcode8
script:
set -o pipefail &&
xcodebuild build -project LayoutKit.xcodeproj -scheme LayoutKitSampleApp -sdk iphonesimulator10.0 --destination-timeout 300
-destination 'platform=iOS Simulator,name=iPhone 6,OS=10.0'
-destination 'platform=iOS Simulator,name=iPhone 6 Plus,OS=10.0' &&
xcodebuild test -project LayoutKit.xcodeproj -scheme LayoutKit -sdk iphonesimulator10.0 --destination-timeout 300
-destination 'platform=iOS Simulator,name=iPhone 6,OS=10.0'
-destination 'platform=iOS Simulator,name=iPhone 6 Plus,OS=10.0'
after_success:
- bash <(curl -s https://codecov.io/bash) |
|
For optimization, I just want this line to disappear from the diff: |
|
fyi, I pushed this as swift3 branch. Will continue to try to get test to pass on travis. |
Hello, LayoutKit is awesome, but I would like to develop apps with Swift 3, unfortunately LayoutKit has no Swift 3 support yet, so I create a new branch for that reason. It's migrated by Xcode 8 beta, I don't touch any API names but I'm not sure if the migrations affect the API names, and fix some un-migratable errors manualy.