This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
Cleanup deprecated configuration options #144
Labels
Milestone
Comments
This was referenced Oct 2, 2015
|
Deprecation candidates
|
General notes:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We should start removing config options that have been formally deprecated or don't appear to be useful anymore. I propose the following...
Formally Deprecated
step.orientation
has been replaced withstep.placement
(since 0.1.0)step.padding
is no longer necessary for placement calculations (since 0.2.0)Undocumented, would like to remove
step.showNumber
is not actually used. The display of the number is currently affected byisTourBubble
instead. Perhaps this is best determined by the existence (or lack thereof) of a step number when callingHopscotchBubble.show()
? (See isTourBubble and showNumber: BUG ? (and an ugly workaround) #131)isTourBubble
should not be a concern of HopscotchCallout. (See isTourBubble and showNumber: BUG ? (and an ugly workaround) #131)Far future (not part of this first pass)
arrowWidth
. We should go ahead and just calculate this with JS instead, like we now do with bubble height/width.nextOnTargetClick
should be moved to a plugin like the one suggested in Tour should advance on other events instead of just 'click' #103, for consistency.The text was updated successfully, but these errors were encountered: