Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon and background are present in dmg, but not appearing when dmg is mounted #84

Closed
geekytime opened this issue Feb 11, 2016 · 15 comments

Comments

@geekytime
Copy link

Here's what my app looks like in the finder before I bundle it in the dmg:

screen shot 2016-02-11 at 3 51 04 pm

Here's what my dmg looks like when I mount it:

screen shot 2016-02-11 at 3 54 27 pm

The size of the background is about right, and the file exist inside the dmg, but that's not how it looked the last time I used appdmg. 😸

I'm also not sure how it could destroy my app's icon like that...

@geekytime
Copy link
Author

Here's my background image:
installer-background

And my icon:
netpegs-logo.icns.zip

And my config file:

{
  "title": "NetPegs",
  "icon": "netpegs-logo.icns",
  "background": "installer-background.png",
  "icon-size": 128,

  "contents": [
    { "x": 318, "y": 200, "type": "file", "path": "./Builds/OSX/NetPegs.app" },
    { "x": 595, "y": 200, "type": "link", "path": "/Applications" }
  ]
}

@geekytime
Copy link
Author

Anyone have any obvious thoughts or suggestions before I start diving into source code? 😦

@LinusU
Copy link
Owner

LinusU commented Feb 11, 2016

Could you start by cloning the repo and running the tests? That should help us locating the problem.

@geekytime
Copy link
Author

Here are the test results. Something certainly seems to be amiss:

Chriss-iMac:node-appdmg Chris$ npm run test

> appdmg@0.3.5 test /Users/Chris/dev/node-appdmg
> standard && mocha -b



  api
    1) creates an image from a modern specification


  0 passing (14s)
  1 failing

  1) api creates an image from a modern specification:
     Error: Image looks visually incorrect
      at test/lib/visually-verify-image.js:31:10
      at node_modules/looks-same/index.js:129:13
      at node_modules/looks-same/index.js:67:13


@geekytime
Copy link
Author

Just for giggles, I uninstalled and reinstalled appdmg. I got some error: messages from xcode-select, but the install succeeded:

Chriss-iMac:node-appdmg Chris$ npm install -g appdmg@latest
/usr/local/bin/appdmg -> /usr/local/lib/node_modules/appdmg/bin/appdmg

> macos-alias@0.2.9 install /usr/local/lib/node_modules/appdmg/node_modules/macos-alias
> node-gyp rebuild

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

  CXX(target) Release/obj.target/volume/src/volume.o
  SOLINK_MODULE(target) Release/volume.node

> fs-xattr@0.1.11 install /usr/local/lib/node_modules/appdmg/node_modules/fs-xattr
> node-gyp rebuild

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

  CXX(target) Release/obj.target/xattr/src/error.o
  CXX(target) Release/obj.target/xattr/src/xattr.o
  SOLINK_MODULE(target) Release/xattr.node
/usr/local/lib
└─┬ appdmg@0.3.5
  ├── async@1.5.2
  ├─┬ ds-store@0.1.4
  │ ├─┬ bplist-creator@0.0.6
  │ │ └── stream-buffers@2.2.0
  │ ├── macos-alias@0.2.9
  │ └── unorm@1.3.3
  ├── fs-temp@1.0.0
  ├─┬ fs-xattr@0.1.11
  │ └── nan@2.2.0
  ├── image-size@0.3.5
  ├── minimist@1.2.0
  └── repeat-string@1.5.2

Obviously, I only have the xcode cli tools installed...

@andrewjaykeller
Copy link

Pretty sure i am having the same issue over here! Installer background not showing on the dmg

@walmink
Copy link

walmink commented Feb 23, 2016

Same issue here. Everything else seems to work fine: no error, files in right location and window is the size of the background image.

Thanks in advance for your help!

@walmink
Copy link

walmink commented Feb 23, 2016

Okay, here's a clue: when I remove the @2x version from the folder, I will see the non-retina version of the background image fine.

@andrewjaykeller
Copy link

Make sure to "eject" your old dmg's!!! That's what fixed this for me

@walmink
Copy link

walmink commented Feb 23, 2016

Thanks, that fixed it for me!

@andrewjaykeller
Copy link

I know!! I couldn't believe that that was it! Glad to hear that worked for you :)

@jbleuzen
Copy link

FYI, I had the exact same problem, background and icon were in the dmg, but when mounting I get the white icon drive and my background was not visible.

Unmounting all dmg and usb didn't work, the solution was to reboot my mac...
Yeah I know....

@libleo
Copy link

libleo commented Apr 15, 2016

Same issue here, but how could resolve that, I don't understand

Error: Image looks visually incorrect???

@cstruct
Copy link
Collaborator

cstruct commented May 22, 2016

Closing this as duplicate of #40

@cstruct cstruct closed this as completed May 22, 2016
@george-hall-ucl
Copy link

Make sure to "eject" your old dmg's!!! That's what fixed this for me

In case this helps others: I found that sometimes old dmgs can still be mounted but not shown in Finder (I think due to botched builds?). These can be unmounted in Disk Utility, finally letting the background update. I guess this is why a restart sometimes appears to be needed to fix this issue, as it unmounts these "hidden" dmgs. Unmounting them in Disk Utility avoids the need to restart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants