-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for inheritance for FHIRPath is and as operators #3974
Comments
For testing, we should add positive and negative test cases to the "official" test suite ( |
Per https://chat.fhir.org/#narrow/stream/179166-implementers/topic/parsing.20polymorphism we'll need to change our ConstraintGenerator in order to make this change without breaking the existing (correct) behavior of our profile validator. That is because we want |
Its the difference between
Two options: A. instead of using B. define a new function, maybe the advantage of of B is that its a bit more concise |
to QA: manually run a handful of fhirpath expressions using maybe also confirm the new |
The task was implemented as requested, but after looking at this again I'm wondering if we should also introduce The background on this one is pretty interesting: However, the official
Furthermore, the spec lists the Anyway, I think most of those expressions and FHIRPath constraints should probably be using the I think its too much of a breaking change to make our |
Describe the bug
add support for inheritance for FHIRPath is and as operators
For example: code data type is a sub type of string, and the validation of expression "code.is(string)" should be successful.
For more information see - https://chat.fhir.org/#narrow/stream/179266-fhirpath/topic/FHIRPath.20.60is.60.20and.20.60as.60.20with.20FHIR.20types
Environment
Which version of LinuxForHealth FHIR Server? 5.0
To Reproduce
Steps to reproduce the behavior:
Expected behavior
evaluator.evaluate(code, "is(string)") should return true
The text was updated successfully, but these errors were encountered: