Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add move painter #473

Closed
1 of 3 tasks
claws99 opened this issue Jul 28, 2023 · 10 comments
Closed
1 of 3 tasks

[Enhancement]: Add move painter #473

claws99 opened this issue Jul 28, 2023 · 10 comments
Assignees
Labels
enhancement Small enhancements to existing features
Milestone

Comments

@claws99
Copy link

claws99 commented Jul 28, 2023

What happened?

Its both a bug and a feature request.

On non-touch devices we use mouse scroll wheel to up and down. I want to scroll to the left and right,

Or bring certain part of the canvas to the center of the screen. Or move the canvas to show desire part. There is no way to do that on windows. Ctrl+Zoomwheel is not a substitute for it. There has to be a better way

Problem is arising because:
Hand tool is selecting stuff on screen, which technically is the function of selection tool (in all other notetaking apps that's what it is called). Moving the canvas should be the job of hand tool.

Solution:

  • Rename the current Hand tool to selection tool & change its icon. (this later on allows us to add other selection modes to it related [Feature request]: Add lasso select #409)
  • Implement hand tool like this:
OneNote.-.Hand.Panning.Tool.mp4

Version

beta5

Platform

Windows

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@claws99 claws99 added the bug Something isn't working label Jul 28, 2023
@CodeDoctorDE
Copy link
Member

CodeDoctorDE commented Jul 28, 2023

On non touch devices you can use the shift key + scroll to move to the left or right, and the middle/right mouse button to move freely

@claws99
Copy link
Author

claws99 commented Jul 28, 2023

icons on https://phosphoricons.com/

hand and hand-grabbing for hand tool

selection for selection tool.

@claws99
Copy link
Author

claws99 commented Jul 28, 2023

On non touch devices you can use the shift key + scroll to move to the left or right, and the middle/right mouse button to move freely

aah! in that case, it will only become an enhancement then.

@CodeDoctorDE
Copy link
Member

Yeah, technically there is already a "Move Painter" that will be added temporarily when you click on the middle mouse button.
I only need to add it to the add dialog for the ui

@CodeDoctorDE CodeDoctorDE added enhancement Small enhancements to existing features and removed bug Something isn't working labels Jul 28, 2023
@CodeDoctorDE CodeDoctorDE added this to the 2.0 milestone Jul 28, 2023
@CodeDoctorDE CodeDoctorDE changed the title [Bug + Enhancement]: No way to drag canvas on non-touch devices [Enhancement]: Add move painter Jul 28, 2023
@claws99
Copy link
Author

claws99 commented Jul 28, 2023

Can we please stick to the general terminology used by other apps ?

Hand tool and selection tool. (even pdf readers use same terminology)

Why break the accepted conventions and confuse the first-time users?

@CodeDoctorDE
Copy link
Member

Tools are already taken for ruler and grid. But we can discuss this on the discord. That's just a new type that will be added

@CodeDoctorDE
Copy link
Member

Added in 2.0.0-beta.6

@CodeDoctorDE
Copy link
Member

I would rename the hand painter after we discuss how we are naming things like painters

@claws99
Copy link
Author

claws99 commented Jul 31, 2023

UI Enhancement:
Change cursor state to hand on selection of tool
onMouseDown cursor start to hand-grabbing

@claws99
Copy link
Author

claws99 commented Jul 31, 2023

Renaming & changing icons:

The current hand tool needs to be

  • renamed to Select
  • icon changed to selection

The laser tool also has the same icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Small enhancements to existing features
Projects
Archived in project
Development

No branches or pull requests

2 participants