Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Multiple transformations using rectangle select tool produce bad results #517

Closed
1 task done
vi opened this issue Oct 31, 2023 · 6 comments
Closed
1 task done
Assignees
Labels
bug Something isn't working confirmed
Milestone

Comments

@vi
Copy link

vi commented Oct 31, 2023

What happened?

On https://preview.butterfly.linwood.dev/ drawing something, then using rectangle select tool, then doing more than one transformation tends to be buggy - it jumps back to previous version after releasing the mouse button.

Sometimes #506-like effect appears.

badselect.webm

Version

No "current version" in "Settings -> General"

Platform

Web

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@vi vi added the bug Something isn't working label Oct 31, 2023
@CodeDoctorDE
Copy link
Member

bug confirmed, thanks for reporting it

@CodeDoctorDE CodeDoctorDE added this to the 2.0 milestone Oct 31, 2023
@CodeDoctorDE
Copy link
Member

Fixed in 2.0.0-beta.14 (1fb4e5d)

@vi
Copy link
Author

vi commented Nov 1, 2023

Better, but rotating, then scaling is still poor:

badselect2.webm

@CodeDoctorDE
Copy link
Member

Rotating is very new currently and it's not easy to make it compatible with all features of the app.
Can you make a new issue with all rotation issues? That would be nice. Then I can try to fix it one by one.
Without rotating, everything should work fine now.

@vi
Copy link
Author

vi commented Nov 1, 2023

Rotating is very new currently and it's not easy to make it compatible with all features of the app.

If you use three-element coordinates (x, y, scale) instead of just (x,y) then rotations (and shears) should be as natural as scaling and translations - all those operations would be matrix multiplications.

@CodeDoctorDE
Copy link
Member

That looks interesting, thanks I will look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed
Projects
Archived in project
Development

No branches or pull requests

2 participants