Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: "Zoom" toggle #538

Closed
1 task done
Luciogi opened this issue Dec 3, 2023 · 14 comments
Closed
1 task done

[Bug]: "Zoom" toggle #538

Luciogi opened this issue Dec 3, 2023 · 14 comments
Assignees
Labels
bug Something isn't working confirmed
Milestone

Comments

@Luciogi
Copy link
Contributor

Luciogi commented Dec 3, 2023

What happened?

butterfly-zoom-slider.mp4

Slider become invisible in fullscreen mode, but it stills function

Version

2.0.0-beta.14

Platform

Android

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Luciogi Luciogi added the bug Something isn't working label Dec 3, 2023
@Luciogi Luciogi changed the title [Bug]: Zoom slide become invisible in fullscreen mode [Bug]: Zoom slider becomes invisible in fullscreen mode Dec 3, 2023
@Luciogi
Copy link
Contributor Author

Luciogi commented Dec 3, 2023

Suggestion: On android having slider is useless, users are tend to use pinch gesture.

  1. Disable zoom slider on android by default
  2. Add toggle in settings

@CodeDoctorDE
Copy link
Member

This is a feature. In full screen mode you should not distracted with other ui elements that are not relevant. Because of this only the toolbar is visible here.
The zoom slider can be toggled in Settings > Personalization > Zoom

@Luciogi
Copy link
Contributor Author

Luciogi commented Dec 3, 2023

This is a feature. In full screen mode you should not distracted with other ui elements that are not relevant. Because of this only the toolbar is visible here. The zoom slider can be toggled in Settings > Personalization > Zoom

I thought it would disable zoom

It should be renamed to "Zoom Slider", which is more descriptive

@CodeDoctorDE
Copy link
Member

Yeah maybe, I just use the translations that I already have.

@Luciogi Luciogi changed the title [Bug]: Zoom slider becomes invisible in fullscreen mode [Bug]: Rename "Zoom" toggle to "Zoom Slider" Dec 3, 2023
@CodeDoctorDE
Copy link
Member

should i close this issue now or do you really need a zoom slider in full screen mode?
i wouldnt call the setting slider because its just a text field on mobile

@Luciogi
Copy link
Contributor Author

Luciogi commented Dec 3, 2023

I would like have zoom slider disabled by default for android devices

@Luciogi
Copy link
Contributor Author

Luciogi commented Dec 3, 2023

i wouldnt call the setting slider because its just a text field on mobile

Fine. Then add description for that toggle

@CodeDoctorDE
Copy link
Member

Do you have a good description to that:
Zoom > The one in the bottom right corner

What I also can do: Limit the slider to a height > 500px. Then it will be changed to a text field that gets hide after 1 second

@Luciogi
Copy link
Contributor Author

Luciogi commented Dec 3, 2023

My brain says Zoom > Toggle zoom sliders

or may be open discussion

@CodeDoctorDE
Copy link
Member

But it's not a slider on every resolution

@Luciogi
Copy link
Contributor Author

Luciogi commented Dec 4, 2023

May be change Zoom to "Alternative Zoom"

@Luciogi
Copy link
Contributor Author

Luciogi commented Dec 5, 2023

@CodeDoctorDE in 2.0.0-rc Settings > Personalization > Zoom is not working :(

How to check?

  • Settings > Personalization > Zoom (off)
  • Go to canvas
  • you will see zoom text field/Slider

@Luciogi Luciogi changed the title [Bug]: Rename "Zoom" toggle to "Zoom Slider" [Bug]: "Zoom" toggle Dec 5, 2023
@CodeDoctorDE
Copy link
Member

that's not good, thanks for reporting.
What about Zoom Floating Control?
It's not really an alternative zoom. It's just another control for the zoom level?

@CodeDoctorDE CodeDoctorDE added this to the 2.0 milestone Dec 5, 2023
@CodeDoctorDE
Copy link
Member

Fixed in 2.0.0-rc.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed
Projects
Archived in project
Development

No branches or pull requests

2 participants