Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Move rotation button to the top #607

Closed
1 task done
Luciogi opened this issue Feb 14, 2024 · 9 comments
Closed
1 task done

[Enhancement]: Move rotation button to the top #607

Luciogi opened this issue Feb 14, 2024 · 9 comments
Assignees
Labels
enhancement Small enhancements to existing features
Milestone

Comments

@Luciogi
Copy link
Contributor

Luciogi commented Feb 14, 2024

Which feature is your request related to?

Selection

Describe your request for enhancements!

Currently, To rotate object user need to drag center of object, and to move drag on non centre part of object
For smaller object, it is not easy to touch and drag non centre part

Suggestion

When object is selected, default mode should be "move"
when users tap/click on selected object it should activate "rotate" mode

Move scaling object with respect to skew and locked aspect ratio to separate tool

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Luciogi Luciogi added the enhancement Small enhancements to existing features label Feb 14, 2024
@CodeDoctorDE
Copy link
Member

I think a separate tool isn't very good because it's overcomplicated it and if we have this new selection system on the area too, we need to have 4 different tools

@Luciogi
Copy link
Contributor Author

Luciogi commented Feb 20, 2024

I think a separate tool isn't very good because it's overcomplicated it and if we have this new selection system on the area too, we need to have 4 different tools

As far I saw, after testing area tool, it does not have rotate and scaling
So, with above suggestion, there would be

  • Selection Tool (that can move and rotate round objects)
  • Scaling Tool

@CodeDoctorDE
Copy link
Member

Hmm, I don't want to create more tools than nessesary. I don't see a big problem having everything in once.

An alternative could be changing the rotation system to the one in office 365:
image
The rotation button here is at the top of the selection

@Luciogi
Copy link
Contributor Author

Luciogi commented Feb 21, 2024

Hmm, I don't want to create more tools than nessesary. I don't see a big problem having everything in once.

An alternative could be changing the rotation system to the one in office 365: image The rotation button here is at the top of the selection

what about scaling ? would it be as it is ?

@CodeDoctorDE
Copy link
Member

Hmm I wouldn't see a problem with this idea. It works on all platforms with touch and mouse and is easy to use

@Luciogi
Copy link
Contributor Author

Luciogi commented Feb 21, 2024

Hmm I wouldn't see a problem with this idea. It works on all platforms with touch and mouse and is easy to use

Ok fine

@CodeDoctorDE CodeDoctorDE changed the title [Enhancement]: rotate and move mode should be changed on tap/click [Enhancement]: Move rotation button to the top Feb 21, 2024
@CodeDoctorDE CodeDoctorDE added this to the 2.1 milestone Feb 21, 2024
@CodeDoctorDE
Copy link
Member

Fixed 5 issues today 🎉 Added in 2.1.0-beta.0

@Luciogi
Copy link
Contributor Author

Luciogi commented Feb 24, 2024

screen-20240224-080638.mp4

Follow up bug:

  • Select and move, is pushing reference point to rotation handle
  • After rotation and moving, breaks lines (may be above behavior is causing this)

@CodeDoctorDE
Copy link
Member

Hi, thanks for reporting. Can you create a new issue for that?
This shouldn't have something to do with this issue. I only changed the display of these handles here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Small enhancements to existing features
Projects
Archived in project
Development

No branches or pull requests

2 participants