Manually send LINK instead of using fund-link task
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `fund-link` task produces logs that clutter up the logs when we are testing. Removes the usage of `fund-link` in the tests, and replaces this with a manual interaction with the `LinkToken` contract. Modify the `tsconfig.json` file so it inspects the types present in `typechain-types`. This resolves an issue with the ethers function `getContractAt`, where it was resolving the return type as a generic `Contract` instead of a concrete contract type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
fund-linktask produces logs that clutter up thelogs when we are testing. Removes the usage of
fund-linkin the tests, and replaces this with a manual interaction
with the
LinkTokencontract.Modify the
tsconfig.jsonfile so it inspects the typespresent in
typechain-types. This resolves an issue withthe ethers function
getContractAt, where it was resolvingthe return type as a generic
Contractinstead of a concretecontract type.