-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phpunit runner fails, wrong directory? #43
Comments
@bojanz Curious for updating my own drupal_ti phpunit-tested modules using composer_manager. Is there a reason in https://github.com/commerceguys/commerce/blob/bec25f7e213fd53c3fdbe98b5aed5adbdf7b951f/.travis-before-script.sh why the composer_manager module isn't enabled first as per the instructions? Or why |
"composer drupal-install" is just "composer drupal-rebuild" + "composer install". As for the module, it doesn't need to be enabled, since it just provides a reports page on the Drupal side. The actual logic is inserted via the init.php script and runs regardless of the module status. |
Hrm, ok I may just lock in using the previous hash of composer_manager in our modules until everything is sorted out then. |
@bojanz I am pretty sure you should be using the 'phpunit-core' runner for commerce in 8.x. phpunit runner should be used for modules using the 'pure' oop way of declaring dependencies on libraries via composer.json, and loading those from a tests/ directory. e.g. cd tests This is especially useful for modules not depending on D8 Core or D7 core in their interfaces. |
I tried to switch to id, but got: Could not read "core". |
We figured this out in IRC - that was core vs. autoloader vs. modules problem. Closing as there is nothing drupal_ti can do for that at this moment. |
Commit:
drupalcommerce/commerce@bec25f7
Result:
https://travis-ci.org/commerceguys/commerce/jobs/76440492
Probably needs a similar fix as mradcliffe@729b806
The text was updated successfully, but these errors were encountered: