Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Setup fee module for DEX sidechain configuration #250

Closed
Tracked by #58
Naureen1lightcurve opened this issue Mar 30, 2023 · 0 comments · Fixed by #262
Closed
Tracked by #58

Setup fee module for DEX sidechain configuration #250

Naureen1lightcurve opened this issue Mar 30, 2023 · 0 comments · Fixed by #262
Labels
type: task
Milestone
Sprint 26

Comments

@Naureen1lightcurve
Copy link
Contributor

Naureen1lightcurve commented Mar 30, 2023 •
edited
Loading

Description

The Fee module now includes a configurable constant ADDRESS_FEE_POOL that allows to activate that all fees that would be burnt are instead transferred to the account ADDRESS_FEE_POOL. Therefore, no modifications of the Fee module are necessary any more and the respective section can be removed.

Acceptance Criteria

  • Configurable constant is setup
  • Unit testing is implemented.
  • All files are updated

Additional Information
@Naureen1lightcurve Naureen1lightcurve added this to the Sprint 23 milestone Mar 30, 2023
@Naureen1lightcurve Naureen1lightcurve mentioned this issue Mar 30, 2023
Closed
7 tasks
@emiliolisk emiliolisk mentioned this issue May 22, 2023
Merged
@Naureen1lightcurve Naureen1lightcurve linked a pull request May 23, 2023 that will close this issue
Setup fee module for DEX sidechain configuration #262
Merged
@emiliolisk emiliolisk mentioned this issue Jun 2, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: task
Projects
None yet
Milestone
Sprint 26
Development

Successfully merging a pull request may close this issue.

Setup fee module for DEX sidechain configuration LiskArchive/lisk-dex-core
3 participants
@Naureen1lightcurve @emiliolisk @Daniel-Lightcurve