Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

Improve signed message output #112

Closed
karmacoma opened this issue Apr 26, 2017 · 0 comments
Closed

Improve signed message output #112

karmacoma opened this issue Apr 26, 2017 · 0 comments
Labels
🌱 enhancement
Milestone
Version 0.4.1

Comments

@karmacoma
Copy link
Contributor

Current behaviour

Interpreting the output, i.e. publicKey from signedMessage is not entirely clear.

-----BEGIN LISK SIGNED MESSAGE-----
Test message
-----BEGIN SIGNATURE-----
37f950fce7051400629cc1a82879b954bbeb6844235b72158f0a49bbc90b14b2
8b4f6e70975bd4b1608434239b38bbaf141d72f2ba5c282985d101a6208248994fe1c1d442e0642ed9c4e4a255c2a387d148f1d3849bd3e45f3617a330fe5a0454657374206d657373616765
-----END LISK SIGNED MESSAGE-----

Desired behaviour

Clearly state sections within signed message output. Something like the following:

-----BEGIN LISK SIGNED MESSAGE-----
-----MESSAGE-----
Test message
-----PUBLIC KEY-----
37f950fce7051400629cc1a82879b954bbeb6844235b72158f0a49bbc90b14b2
-----SIGNATURE-----
8b4f6e70975bd4b1608434239b38bbaf141d72f2ba5c282985d101a6208248994fe1c1d442e0642ed9c4e4a255c2a387d148f1d3849bd3e45f3617a330fe5a0454657374206d657373616765
-----END LISK SIGNED MESSAGE-----

Steps to reproduce

Use signAndPrintMessage or printSignedMessage functions located within the crypto/sign module.
@karmacoma karmacoma added this to the Version 1.0.0 milestone Apr 26, 2017
@karmacoma karmacoma added this to Backlog in Version 1.0.0 Apr 26, 2017
@karmacoma karmacoma mentioned this issue Apr 26, 2017
Closed
@karmacoma karmacoma removed this from Backlog in Version 1.0.0 Apr 26, 2017
@karmacoma karmacoma added this to Backlog in Version 0.4.1 Apr 26, 2017
@toschdev toschdev moved this from Backlog to In Progress in Version 0.4.1 Apr 26, 2017
@toschdev toschdev mentioned this issue Apr 26, 2017
Merged
@karmacoma karmacoma removed this from In Progress in Version 0.4.1 Apr 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🌱 enhancement
Projects
None yet
Milestone
Version 0.4.1
Development

No branches or pull requests
1 participant
@karmacoma