Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

Add minimal controls for arguments related to assets #315

Closed
diego-G opened this issue Aug 17, 2017 · 1 comment
Closed

Add minimal controls for arguments related to assets #315

diego-G opened this issue Aug 17, 2017 · 1 comment

Comments

@diego-G
Copy link

diego-G commented Aug 17, 2017

By the time being, lisk-js relais on schema validations from core. Even though, we should implement minimal controls to ensure a proper argument processing inside the application.

I tag the issue as a bug because the application doesn't handle some exceptions properly. For example when using createVote with delegates argument as null. Below the output log:

vote.createVote(account.password, null)

TypeError: Cannot read property 'join' of null
    at Object.isVoteTransaction (node_modules/lisk-js/dist-node/transactions/crypto.js:85:65)
    at getTransactionBytes (node_modules/lisk-js/dist-node/transactions/crypto.js:208:42)
    at createTransactionBuffer (node_modules/lisk-js/dist-node/transactions/crypto.js:339:35)
    at getBytes (node_modules/lisk-js/dist-node/transactions/crypto.js:357:9)
    at getHash (node_modules/lisk-js/dist-node/transactions/crypto.js:386:14)
    at Object.sign (node_modules/lisk-js/dist-node/transactions/crypto.js:410:13)
    at prepareTransaction (node_modules/lisk-js/dist-node/transactions/utils.js:32:31)
    at Object.createVote (node_modules/lisk-js/dist-node/transactions/vote.js:62:40)
@diego-G diego-G added this to the Version 1.0.0 milestone Aug 17, 2017
@diego-G diego-G changed the title Create control for delegates argument in createVote() Add control for delegates argument in createVote() Aug 17, 2017
@willclarktech willclarktech added this to Backlog in Version 1.0.0 Aug 17, 2017
@diego-G diego-G changed the title Add control for delegates argument in createVote() Add minimal controls for arguments related to assets Aug 23, 2017
@toschdev
Copy link
Contributor

This will be solved by #417 so I am closing this issue

@toschdev toschdev moved this from Issues to Closed Issues in Version 1.0.0 Nov 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Version 1.0.0
  
Closed Issues
Development

No branches or pull requests

2 participants