Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Move NetworkConfig to P2P package #71

Closed
Tracked by #1
matjazv opened this issue Feb 27, 2023 · 0 comments · Fixed by #87
Closed
Tracked by #1

Move NetworkConfig to P2P package #71

matjazv opened this issue Feb 27, 2023 · 0 comments · Fixed by #87
Labels
type: refactoring
Milestone
Sprint 8

Comments

@matjazv
Copy link
Contributor

matjazv commented Feb 27, 2023

Description

At the moment, NetworkConfig is inside engine module. Dependency wise it would be better if this config will be inside P2P package.
For engine needs define a new config or reuse one from P2P package.

Acceptance Criteria

  • NetworkConfig is part of P2P package
  • All new code is unit tested.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: refactoring
Projects
None yet
Milestone
Sprint 8
Development

Successfully merging a pull request may close this issue.

Separate engine config and P2P config LiskArchive/lisk-engine
2 participants
@matjazv @Madhulearn