Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Resolve memory leaks #1103

Closed
MaciejBaj opened this issue Dec 8, 2017 · 1 comment
Closed

Resolve memory leaks #1103

MaciejBaj opened this issue Dec 8, 2017 · 1 comment
Assignees

Comments

@MaciejBaj
Copy link
Contributor

MaciejBaj commented Dec 8, 2017

Devnet tests of 1.0.0 version revealed memory leaks while operating on 10 nodes. Average memory consumption was raising linearly on every machine.

Further investigation (performing heap snapshots of running Lisk Core instances being part of Devnet) lead into the observation that backing_store [JSArrayBufferData] variable of bson library consumes 40% of 130 MB total memory used by the application.

Usage of bson library was introduced to 1.0.0 codebase as a part of #541 - Use binary format. Connecting the node without block serialization/deserialization to Devnet resulted in eliminating of linearly increasing memory consumption on the hosting machine.

Blocks serialization/deserialization to binary format needs to be re-reviewed to spot and resolve potential memory leaks problems.

@MaciejBaj MaciejBaj changed the title Memory leaks on current 1.0.0 version Memory leaks on 1.0.0 version Dec 8, 2017
@MaciejBaj MaciejBaj changed the title Memory leaks on 1.0.0 version Resolve memory leaks in blocks serialization Dec 8, 2017
@karmacoma karmacoma added *medium and removed *hard labels Jan 4, 2018
@karmacoma karmacoma removed the *medium label Feb 1, 2018
@MaciejBaj
Copy link
Contributor Author

MaciejBaj commented Feb 1, 2018

Analyze of heap snapshots taken from nodes running 1.0.0 devnet, revealed an issue with storing huge amounts of RPC calls in memory.
screen shot 2018-02-01 at 12 14 37
The issue is caused by wamp-socket-cluster library which uses lodash.get and lodash.set functions to access/store performed RPC calls. The further description is provided in issue description: LiskArchive/wamp-socket-cluster#24. After eliminating the cause in wamp-socket-cluster library, this issue should be closed by updating the wamp-socket-cluster version.

@karmacoma karmacoma added the *hard label Feb 7, 2018
@MaciejBaj MaciejBaj changed the title Resolve memory leaks in blocks serialization Resolve memory leaks Feb 7, 2018
shuse2 referenced this issue Apr 15, 2019
…domly

Integration tests failing randomly due to low timeout - Closes#1103
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants